Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bundle-source): Remove vestigial internal dev option #2433

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

kriskowal
Copy link
Member

This removes dead code. The bundler uses the dev flag only for discovery of devDependencies in mapNodeModules, and makes no further use of it in the bundling kit.

@kriskowal kriskowal requested a review from erights August 27, 2024 19:07
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriskowal kriskowal merged commit 0517f2c into master Aug 27, 2024
17 checks passed
@kriskowal kriskowal deleted the kriskowal-bundle-source-vestigial-dev branch August 27, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants